feat(data): an accepted offer on every hired application; seed-count docs read 818 - #64

Closes #53
Closes #61

The state machine reaches hired only from offer (DESIGN.md §02) and F3 writes the offer row, so a hired application without an offer is a history the app cannot produce — yet on origin/main 0ad34d7 all 14 seeded ats_offer rows sit on offer-stage applications and none of the 9 hired ones has one. This PR gives each hired application one accepted offer, in both locale packs through scopeToDemo(), and moves every seed-count statement to what a boot now logs (818). #61 is folded in: AGENTS.md and the src/data/index.ts comment still said 801 / 794.

Sizing decision: 14 → 23, not a re-balance

Every offer-stage application needs its offer for the same state-machine reason the hired ones do (F3 produced it), so the 14 existing rows cannot be redistributed; a re-balance inside 14 would mean moving applications between stages, which moves the 88 / 46 / 28 / 14 / 9 funnel that the release screenshots and docs/screenshots/README.md show. Adding 9 rows keeps every application count where it was — verified below, not assumed.

What changed

Not touched (⛔ per the card): src/security/, src/objects/, src/hooks/, src/flows/, src/views/, src/apps/, src/dashboards/, src/datasets/. No new label, option or field, so --i18n-strict had nothing new to check. No dependency change.

Gates — pnpm validate && pnpm lint && pnpm typecheck on 54a442c

Run through os-verify-lock.sh (exit codes captured before any pipe; the lock prints the verdict line):

=== pnpm validate exit=0 ===
  Data: 12 Objects  146 Fields
  UI: 1 Apps  10 Views  3 Dashboards  4 Actions
  Logic: 6 Flows
  Security: 5 Positions  5 Permissions
  Runtime: 2 plugins
  ⚠ flow "employer_verification" · node "ops_review": every approver on this node routes to a group … (3 pre-existing approval-approvers-may-resolve-empty warnings, unchanged)
os-verify-lock: VERDICT command-exit 0 · held the lock 4s · waited 0s

=== pnpm lint exit=0 ===
  Suggestions (3)  … approval-approvers-may-resolve-empty ×3 (pre-existing, unchanged)
  3 suggestion(s) (858ms)
  platform built-ins: 773 i18n issue(s) hidden — rerun with --include-platform to audit them
os-verify-lock: VERDICT command-exit 0 · held the lock 4s · waited 0s

=== pnpm typecheck exit=0 ===
> ats@0.1.0 typecheck /home/user/ats-issue-53
> tsc --noEmit
os-verify-lock: VERDICT command-exit 0 · held the lock 7s · waited 0s

CI (.github/workflows/ci.yml) runs the same three on this PR.

Artifact join — npx objectstack build, dist/objectstack.json

The reproduce one-liner from #53, plus the hired ⟷ offer join, before and after:

Runtime read-back — memory driver, port 4403

OS_PLATFORM_OWNER_EMAIL=admin@objectos.ai npx objectstack dev --fresh --database-driver memory -p 4403 --log-level info, counted only after the seeder line:

before  INFO [ats] demo seed enabled: … loading 17 datasets, 809 rows, 7 demo logins (README.md)
before  INFO [Seeder] Seed loading complete {"inserted":809,"updated":0,"skipped":0,"errored":0}
after   INFO [ats] demo seed enabled: … loading 17 datasets, 818 rows, 7 demo logins (README.md)
after   INFO [Seeder] Seed loading complete {"inserted":818,"updated":0,"skipped":0,"errored":0}

Per persona, GET /api/v1/data/OBJECT?$top=1&$count=true (total) after POST /api/v1/auth/sign-in/email:

The new rows as the employer persona reads them (GET /api/v1/data/ats_offer?$filter={"status":"accepted"}), CEL dates resolved at seed time:

## quillstone_admin: accepted offers total=1
   {"display_name": "Offer · Avery Lindqvist → Robotics Software Engineer", "status": "accepted", "start_date": "2026-09-18", "expires_at": "2026-09-02", "approved_by": "usr_ats_quillstone_admin", "salary": 150000, "salary_period": "yearly"}
## harborline_admin: accepted offers total=2
   {"display_name": "Offer · Elena Petrova → Welder", "status": "accepted", "start_date": "2026-09-03", "expires_at": "2026-08-13", "approved_by": "usr_ats_harborline_admin", "salary": 30, "salary_period": "hourly"}
   {"display_name": "Offer · Karin Lindgren → Welder", "status": "accepted", "start_date": "2026-09-06", "expires_at": "2026-08-21", "approved_by": "usr_ats_harborline_admin", "salary": 30, "salary_period": "hourly"}
## seeker candidate01: accepted offers total=1
   {"display_name": "Offer · Avery Lindqvist → Robotics Software Engineer", "status": "accepted", "start_date": "2026-09-18", "expires_at": "2026-09-02", "approved_by": "usr_ats_quillstone_admin", "salary": 150000, "salary_period": "yearly"}

Platform personas read 23 here because this is the memory driver; on sqlite ats_offer reads 0 to them (#39, expected, not touched).

Employer dashboard (ats_employer_hiring) before / after — unchanged, as it must be

None of its four widgets reads ats_offer (job, application, interview datasets only), so the numbers cannot move; measured anyway, both employer personas, POST /api/v1/analytics/dataset/query with the widget's own filter as selection.runtimeFilter, cross-checked against a REST $filter count (compiled SQL in the probe output shows the filter and the row-level scope both applied):

REST cross-check column agreed with every analytics number in both runs. (Measurement note for whoever probes this next: a filter placed at body.filter, selection.filter, filters or where is accepted with HTTP 200 and silently ignored — the compiled SQL carries only the row-level scope, and Quillstone's open_jobs reads 5; the key the analytics service reads is selection.runtimeFilter. The Console uses that key, which is why the screenshots show 3 / 18 / 6.)

Doc consistency — every seed-count statement now agrees

Screenshots — still valid, by count

Stage counts did not move: 88 / 46 / 28 / 14 / 9 marketplace-wide (artifact and the funnel dataset both), Quillstone 10 / 8 / 5 / 2 / 1 (+1 rejected) on the kanban and the Hiring Overview bar. Platform Overview reads employers / jobs / applications / candidates — none changed. The interview calendar reads ats_interview (40, unchanged); Find Jobs reads ats_job (22 published, unchanged). No shot reads ats_offer, so none was reshot.

Left as found, on purpose

• src/dashboards/employer-hiring.dashboard.ts — its comment's third bullet ("the demo seed has no offer on any hired application (its 14 offers all sit on offer-stage applications)") is now false, but src/dashboards/ is on this card's ⛔ list and Time-to-offer on the employer dashboard: stamp the duration on ats_application, seed offers for hired applications, and correct §04's wording #55 — which builds that very tile and lists "Demo seed: no ats_offer row belongs to a hired application — all 14 offers sit on offer-stage applications, so "days to offer for hired applications" is unmeasurable on the seed #53's seed fix" inside its own scope — will rewrite the block. After this merges, Time-to-offer on the employer dashboard: stamp the duration on ats_application, seed offers for hired applications, and correct §04's wording #55's scope bullet on seeding offers is already done and its body item 4 is stale; flagged in the dev-report rather than edited here.
• docs/evidence/issue-8/* and docs/backlog/10-seed-data.md still say 14 offers / 809 rows: dated measurement records and the original card, not living statements.
• Application a106 stays at stage offer with a declined offer — a legitimate transient (employer deciding whether to counter), pre-existing, not a state the machine forbids; noted, not changed.

🤖 Generated with Claude Code

https://claude.ai/code/session_01PbJ5Cy9KDAzeQHo8bsMadG

Generated by Claude Code